visual C# windows form project, cannot assign to a "using variable"

Question

Hi, this code I want to identify the ID of the PC (processor + motherboard), so that I can use later for the database of the users.

Here code:

using (ManagementObjectCollection objectList = null)

{

ManagementObjectSearcher objectSearcher = new ManagementObjectSearcher("Select * From Win32_processorID");

objectList = objectSearcher.Get();

string id = "";

foreach (ManagementObject obj in objectList)

{

id = obj["processorID"].ToString();

}

objectSearcher = new ManagementObjectSearcher("Select * From Win32_BaseBoard");

objectList = objectSearcher.Get();

string motherBoard = "";

foreach (ManagementObject obj in objectList)

{

motherBoard = obj["SerialNumber"].ToString();

}

string uniqueID = id + motherBoard;

}

I get an error: cannot assign to "objectList" because it is using variable.

I tried not to use using, I get another error, the class cannot be recognized.

Anyone knows the solution.

Thanks in advance, Genandy

Accepted Answer

Here's the corrected code:

using System;
using System.Management;

class Program
{
    static void Main()
    {
        try
        {
            // Get Processor ID
            string processorId = "";
            using (ManagementObjectSearcher searcher = new ManagementObjectSearcher("SELECT ProcessorId FROM Win32_Processor"))
            {
                foreach (ManagementObject obj in searcher.Get())
                {
                    processorId = obj["ProcessorId"]?.ToString();
                }
            }

            // Get Motherboard Serial Number
            string motherboardSerial = "";
            using (ManagementObjectSearcher searcher = new ManagementObjectSearcher("SELECT SerialNumber FROM Win32_BaseBoard"))
            {
                foreach (ManagementObject obj in searcher.Get())
                {
                    motherboardSerial = obj["SerialNumber"]?.ToString();
                }
            }

            // Combine IDs for Unique Identification
            string uniqueID = processorId + motherboardSerial;
            Console.WriteLine($"Unique ID: {uniqueID}");
        }
        catch (Exception ex)
        {
            Console.WriteLine($"Error: {ex.Message}");
        }
    }
}

Notes:

Make sure to run the application with administrative privileges, as WMI queries often require them.
The above code assumes the System.Management namespace is included in your project. If it's not available, add a reference to the System.Management assembly.

Answer

You cannot do that. When you use a using statement it basically is capturing the value of the variable and storing it off so it can be cleaned up once the scope is exited. If you were allowed to change the value pointed to by the variable after the fact then you would potentially leak the object. Case in point.

using (var cleanMeUp = GetObjectThatRequiresCleanup())
{
   //Not going to clean it up anymore...
   cleanMeUp = null;
};

The variable inside the using statement scope is therefore readonly as discussed in the docs. It's value cannot be changed once it is set.

Given your code the correct solution is to use a separate using statement for each call to Get which returns a new, disposable object. That is probably how I'd handle it.

If you need to aggregate multiple IDisposable objects together then create a wrapper type DisposableCollection. The collection stores IDisposable objects in it. When the collection is disposed it cleans up any stored objects. Add any objects you need to clean up to this collection and create the collection as part of the using statement.

using (var items = new DisposableCollection())
{
    var dataToClean = GetDataToClean();
    items.AddRange(dataToClean);    
};

The biggest issue with this code is that if it fails after getting the data to clean and before it is added to the collection then you're going to leak objects. But it does allow for tracking objects across sources.

Personally I'd just use multiple using statements as that is realistically what you want to happen anyway.

Share via

visual C# windows form project, cannot assign to a "using variable"

1 additional answer

Your answer